Carmen Bianca BAKKER [Wed, 12 Feb 2020 07:43:58 +0000 (07:43 +0000)]
Update Esperanto translation
Matthias Clasen [Tue, 11 Feb 2020 19:01:10 +0000 (19:01 +0000)]
Merge branch 'mark-events-with-kind' into 'master'
profiler: Always mark events with the kind
See merge request GNOME/gtk!1414
Alexander Larsson [Tue, 11 Feb 2020 18:51:49 +0000 (19:51 +0100)]
profiler: Always mark events with the kind
Matthias Clasen [Tue, 11 Feb 2020 16:59:11 +0000 (16:59 +0000)]
Merge branch 'wip/baedert/outline-radius' into 'master'
css boxes: Compute box from border box
Closes #2425
See merge request GNOME/gtk!1408
Emmanuele Bassi [Tue, 11 Feb 2020 16:30:16 +0000 (16:30 +0000)]
Merge branch 'share-gl-programs' into 'master'
GskGLRenderer: Share programs between different renderers in same display
See merge request GNOME/gtk!1413
Matthias Clasen [Tue, 11 Feb 2020 16:23:02 +0000 (16:23 +0000)]
Merge branch 'handle-max-texture-size' into 'master'
gl: Don't require too large texture for offsreen ops
See merge request GNOME/gtk!1411
Matthias Clasen [Tue, 11 Feb 2020 16:17:14 +0000 (16:17 +0000)]
Merge branch 'fix-angle-normalization' into 'master'
gsk: Fix angle normalization
See merge request GNOME/gtk!1409
Alexander Larsson [Tue, 11 Feb 2020 15:56:24 +0000 (16:56 +0100)]
GskGLRenderer: Share programs between different renderers in same display
This is similar to how we share texture atlases. Some added complexity
in that the program state also needed to be shared, so it had to move to
the shared Programs object.
With this change realization of additional GskRenderers when opening
popups went from ~60msec to ~35 msec on average.
Emmanuele Bassi [Tue, 11 Feb 2020 15:25:48 +0000 (15:25 +0000)]
Merge branch 'ci-jobs' into 'master'
Update CI jobs
See merge request GNOME/gtk!1412
Emmanuele Bassi [Tue, 11 Feb 2020 15:12:14 +0000 (15:12 +0000)]
ci: Allow release job to fail
We need to investigate release-specific failures, and possibly fix our
test suite to deal with debug-specific poking through the internal
state.
For the time being, allow the release job to fail, but this is strictly
a temporary measure.
Emmanuele Bassi [Tue, 11 Feb 2020 14:53:57 +0000 (14:53 +0000)]
testsuite/gtk: Add xfail tests
Some tests are expected to fail.
Some tests are expected to fail in non-debugging builds.
The icontheme test is the latter.
Emmanuele Bassi [Tue, 11 Feb 2020 14:07:43 +0000 (14:07 +0000)]
vulkan: Handle VK_ERROR_UNKNOWN
A newly added Vulkan 1.2 error.
Emmanuele Bassi [Tue, 11 Feb 2020 13:28:16 +0000 (13:28 +0000)]
ci: Add a style check pass
We should at least try to get the style check done by a machine, as
opposed to have humans go through merge requests with coding style
nitpicks.
Emmanuele Bassi [Wed, 29 Jan 2020 13:36:23 +0000 (14:36 +0100)]
ci: Generate the report for the release builds
We are going to need to hide the report generation into the test runner
script, as we want the job to produce the reports even in case of
failure, instead of bailing out immediately.
Emmanuele Bassi [Wed, 29 Jan 2020 13:03:56 +0000 (14:03 +0100)]
Declare global counters only in debug builds
Emmanuele Bassi [Wed, 29 Jan 2020 13:02:41 +0000 (14:02 +0100)]
Silence compiler warnings in non-debug builds
Emmanuele Bassi [Wed, 29 Jan 2020 13:02:16 +0000 (14:02 +0100)]
Declare global counter only in debug builds
Matthias Clasen [Tue, 11 Feb 2020 14:06:36 +0000 (14:06 +0000)]
Merge branch 'fix-revealer-scale' into 'master'
revealer: Fix child size allocation at small scales
See merge request GNOME/gtk!1410
Emmanuele Bassi [Wed, 29 Jan 2020 11:31:00 +0000 (12:31 +0100)]
ci: Add missing newline escape
Otherwise we're going to run the accessibility test suite, and it's
going to fail.
Emmanuele Bassi [Wed, 29 Jan 2020 11:23:06 +0000 (12:23 +0100)]
ci: Remove static build job
Now that we figured out why the build was failing on Fedora when the
profiling code was enabled, we can go back to building both shared and
static libraries by default.
Emmanuele Bassi [Wed, 29 Jan 2020 11:18:09 +0000 (12:18 +0100)]
ci: Use the new Fedora image
Emmanuele Bassi [Wed, 29 Jan 2020 11:16:44 +0000 (12:16 +0100)]
ci: Add static packages for GLib and PCRE
Otherwise Meson will warn about missing static dependencies for
sysprof-capture-3.
Emmanuele Bassi [Wed, 29 Jan 2020 11:00:48 +0000 (12:00 +0100)]
Fix compiler warnings in the release build
We have a bunch of debug-only variables that get set and never used
outside of debug code paths, and the compiler is not happy about it.
Emmanuele Bassi [Wed, 29 Jan 2020 10:45:33 +0000 (11:45 +0100)]
ci: Disable ccache
Emmanuele Bassi [Wed, 29 Jan 2020 10:34:11 +0000 (11:34 +0100)]
Initialise out variable
Otherwise we might return an undefined value, and the compiler will be
very cross at us.
Emmanuele Bassi [Wed, 29 Jan 2020 10:31:47 +0000 (11:31 +0100)]
ci: Split the static and shared builds (again)
Sadly, we can't do a static build with the profiling code enabled
because we don't have a static GLib build available.
Emmanuele Bassi [Wed, 29 Jan 2020 10:01:10 +0000 (11:01 +0100)]
ci: Replicate the CI image scripts from GLib
They are easier to use and document, and allow us to add new base images
in the future without making a mess.
Emmanuele Bassi [Wed, 29 Jan 2020 09:35:10 +0000 (10:35 +0100)]
ci: Refactor the CI pipeline
We should have a single job for building both static and shared
versions of GTK. On the other hand, having a separate job for the
release build would be a plus.
Additionally, we shouldn't use an opaque script to build GTK; the only
step in the process that requires hand-holding is running the tests
suites under Xvfb, and having the build options visible from the YAML
file gives us a better idea of what kind of build we're running.
Emmanuele Bassi [Wed, 29 Jan 2020 09:34:41 +0000 (10:34 +0100)]
ci: Use release builds for Flatpak bundles
Chun-wei Fan [Tue, 11 Feb 2020 12:46:19 +0000 (20:46 +0800)]
tests/frame-stats.c: Include stdlib.h
It is used for exit().
Alexander Larsson [Tue, 11 Feb 2020 11:22:34 +0000 (12:22 +0100)]
revealer: Fix child size allocation at small scales
As pointed out in https://gitlab.gnome.org/GNOME/gtk/issues/1481
and seen from critical warnings with swinging revealers in widget-factory
there are some size allocation issues in GtkRevealer.
What happens is that we request a size of the revealer itself
based on the child natural size and the current stage of the transition
by applying a scale to the natural size. We then round up to nearest
int size. However, we want the widget to render as if it did get the
natural size so we can transform it, rather than the scaled down size.
For example, a label should not start ellipsizing in the animation.
So we inverse the scale when allocating the child.
Unfortunately, for very small scales the inversion of the scale can
result in very large sizes, and for such scales we rounded up the
requested size to 1, so we will be allocating huuuuge children.
In order to avoid such issue we pick an arbitrary maximum upscale
scale factor of 100. This means that in the case where the allocated
size is 1 we never allocate the child at > 100 px. This means
that in large downscaling cases we may run into the clipping issue
described above. However, at these downscaling levels (100 times!)
we're unlikely to notice much detail anyway.
Alexander Larsson [Tue, 11 Feb 2020 09:00:34 +0000 (10:00 +0100)]
gsk: Fix angle normalization
I was getting assertions that normalize_angle() failed the
result < 260 check. Doing some research on this it turns out
to be a precision issue. If the incomming angle is very slightly
below zero, then adding 360 to it may end up with exactly 360.
I simplified the code a bit to avoid division and rounding, because in
practice most angles will be "just outside" the 0-360 degree anyway.
And i also added a workaround for the "result is 360" case by just
setting it to 0.
Alexander Larsson [Tue, 11 Feb 2020 12:01:27 +0000 (13:01 +0100)]
gl: Don't require too large texture for offsreen ops
When rendering ops to an offscreen texture we take max-texture-size
in consideration and modify the scale we use such that the required
texture does not exceed the limit.
This means some rendering will be blocky/fuzzy, but that is better
than it being clipped.
Matthias Clasen [Tue, 11 Feb 2020 12:46:12 +0000 (07:46 -0500)]
Typo fix
Matthias Clasen [Tue, 11 Feb 2020 12:44:01 +0000 (07:44 -0500)]
Revert "Add the label-wrap-justify reftest to xfails"
This reverts commit
5e746d35b2c5ab8601b493d4f8ca4784328d50fa.
Turns out label-wrap-justify isn't failing in ci, and this is
now making ci fail :(
Timm Bäder [Tue, 11 Feb 2020 07:29:11 +0000 (08:29 +0100)]
css boxes: Compute inline box from border box
We can't just use the outline rect and apply the border radius because
the outline box is the border box grown by the outline offset, which
will also grow the resulting border radius.
Fixes #2425
Matthias Clasen [Mon, 10 Feb 2020 20:32:19 +0000 (15:32 -0500)]
3.98.0
Matthias Clasen [Mon, 10 Feb 2020 20:19:13 +0000 (15:19 -0500)]
Add the label-wrap-justify reftest to xfails
Seems just like the other label tests, down to details
of text rendering.
Matthias Clasen [Mon, 10 Feb 2020 20:15:05 +0000 (15:15 -0500)]
Drop the toplevel-vs-popup reftest
Popups look different from toplevels. I don't think
a reftest that tries to prove otherwise has much
leg to stand on.
Matthias Clasen [Mon, 10 Feb 2020 20:06:56 +0000 (15:06 -0500)]
Disable the buttons a11y test
The test fails because radio buttons are currently broken.
Matthias Clasen [Mon, 10 Feb 2020 20:03:47 +0000 (15:03 -0500)]
Update expected test output
The a11y test for GtkAssistant produces different
output due to headerbar changes.
Matthias Clasen [Mon, 10 Feb 2020 19:59:40 +0000 (14:59 -0500)]
calendar: Fix mismatches with GDateTime
GDatetime uses 1-based month and day numbers, whereas
GktCalendars are 0-based. Correct for this.
Matthias Clasen [Mon, 10 Feb 2020 19:14:18 +0000 (14:14 -0500)]
Calendar: Make year/month/day writable again
Our a11y tests were relying on this.
Matthias Clasen [Mon, 10 Feb 2020 18:55:37 +0000 (13:55 -0500)]
testsuite: Update expected output
The output for combo boxes in a11y tests has changed
because they use popovers now.
Matthias Clasen [Mon, 10 Feb 2020 15:57:54 +0000 (15:57 +0000)]
Merge branch 'fix-gestures-test' into 'master'
Fix gestures test
See merge request GNOME/gtk!1406
Alexander Larsson [Mon, 10 Feb 2020 15:24:03 +0000 (16:24 +0100)]
Fix gestures test
This tests was testing gestures by faking an event in the
middle of a window that has a hbox with an expanding image in it.
For me (and I guess this depends on all sorts of issues like whether
CSD is enabled, font sizes, etc) the hbox ended up centered horizontally
but not vertically (probably because of csd at the top), so no events
ever hit the inner widgets.
This is fixed by emitting the events at allocation.x/y of the
hbox, which should contain both the hbox and the image (as it expands).
Matthias Clasen [Mon, 10 Feb 2020 15:08:51 +0000 (15:08 +0000)]
Merge branch 'fix-hidpi-popups' into 'master'
Fix popup placement on hidpi multi-monitor
See merge request GNOME/gtk!1405
Alexander Larsson [Mon, 10 Feb 2020 14:19:32 +0000 (15:19 +0100)]
hidpi: Rescan monitors when screen scale factor changes
All the code in e.g. init_randr15() divides the physical resolutions with
the screen scale, however if we get the screen scale from xsettings
rather than e.g. GDK_SCALE the initial setup is using the wrong value.
So, whenever the screen scale size is changed we need to trigger
a re-read of the randr data
Matthias Clasen [Mon, 10 Feb 2020 14:32:09 +0000 (14:32 +0000)]
Merge branch 'mainloop-cleanup' into 'master'
Mainloop cleanup
See merge request GNOME/gtk!1404
Matthias Clasen [Mon, 10 Feb 2020 13:13:23 +0000 (08:13 -0500)]
More updates
Alexander Larsson [Mon, 10 Feb 2020 12:45:56 +0000 (12:45 +0000)]
Merge branch 'icon-theme-api-rework' into 'master'
Icon theme api rework
See merge request GNOME/gtk!1390
Alexander Larsson [Mon, 10 Feb 2020 12:30:57 +0000 (13:30 +0100)]
Fix typo in GtkIconPaintable is-symbolic property
Alexander Larsson [Mon, 10 Feb 2020 12:12:26 +0000 (13:12 +0100)]
icon-theme: Add back and fix test for handling non-square icons
We test this by looking at the produced render nodes now that
we don't actualluy scale the icon. Also, it turns out that this
code was broken due to some typos, so we also fix those.
Alexander Larsson [Mon, 10 Feb 2020 11:57:27 +0000 (12:57 +0100)]
Expose gtk_icon_paintable_new_for_file
Alexander Larsson [Mon, 10 Feb 2020 11:51:27 +0000 (12:51 +0100)]
GtkIconPaintable: Add properties for file, icon-name and is-symbolic
Matthias Clasen [Mon, 10 Feb 2020 12:07:18 +0000 (12:07 +0000)]
Merge branch 'baselineoverlay' into 'master'
A baseline overlay
See merge request GNOME/gtk!840
Alexander Larsson [Mon, 10 Feb 2020 11:33:17 +0000 (12:33 +0100)]
icon paintable: Replace get_filename and get_resource_path with get_file()
This returns a GFile which can represent both the above.
Alexander Larsson [Mon, 10 Feb 2020 10:43:47 +0000 (11:43 +0100)]
Rename GTK_ICON_LOOKUP_LOAD_IN_THREAD to GTK_ICON_LOOKUP_PRELOAD
Alexander Larsson [Mon, 10 Feb 2020 10:40:00 +0000 (11:40 +0100)]
icontheme: Always return some icon name in get_icon_name() for lookup results
If you called gtk_icon_theme_lookup(), then always return some useful
icon name from gtk_icon_paintable_get_icon_name(), even if we picked
an unthemed icon.
Also rewrite the gtk_icon_paintable_get_icon_name() docs to make this
clearer.
Matthias Clasen [Mon, 13 May 2019 17:43:44 +0000 (17:43 +0000)]
Remove GTK_DEBUG=baselines
This has been reimplemented differently
in the inspector.
Matthias Clasen [Mon, 13 May 2019 17:42:20 +0000 (17:42 +0000)]
widget: Stop embedding baseline debugging
The inspector has an overlay that achieves the
same, in a cleaner way.
Matthias Clasen [Mon, 13 May 2019 17:36:46 +0000 (17:36 +0000)]
inspector: Draw baselines as an overlay
Matthias Clasen [Mon, 10 Feb 2020 04:40:02 +0000 (23:40 -0500)]
Remove unused includes
We eventually want to get rid of GtkSelectionData.
As a first step, stop including gtkselection.h unnecessarily.
Matthias Clasen [Mon, 10 Feb 2020 03:47:25 +0000 (22:47 -0500)]
docs: Mention gtk_main in the migration guide
Matthias Clasen [Mon, 10 Feb 2020 03:37:18 +0000 (22:37 -0500)]
Drop gtk_get_main_thread
This is not a very useful api, and if you need it,
you can just as easily keep track yourself which thread
called gtk_init().
Matthias Clasen [Mon, 10 Feb 2020 03:33:02 +0000 (22:33 -0500)]
Drop gtk_main and gtk_main_quit
The alternatives are to use GtkApplication,
or use GMainContext.
Matthias Clasen [Mon, 10 Feb 2020 03:41:58 +0000 (22:41 -0500)]
docs: Update an example
Don't use gtk_main() in the mainloop example.
It is going away.
Matthias Clasen [Mon, 10 Feb 2020 03:24:47 +0000 (22:24 -0500)]
Stop using gtk_main and gtk_main_quit
Replace these calls with direct use of GMainContext api.
Matthias Clasen [Mon, 10 Feb 2020 01:06:58 +0000 (20:06 -0500)]
Stop using gtk_main_quit
Stop using gtk_main and gtk_main_quit in tests and
examples. These APIs are on the way out.
Matthias Clasen [Mon, 10 Feb 2020 00:42:11 +0000 (19:42 -0500)]
Drop gtk_main_level
This api isn't useful without gtk_main, which is also
on the way out.
Matthias Clasen [Mon, 10 Feb 2020 00:38:40 +0000 (19:38 -0500)]
Drop gtk_main_iteration
This function and its cousin, gtk_main_iteration_do, are
thin wrappers around GMainContext api that should just
be used directly.
Matthias Clasen [Mon, 10 Feb 2020 00:34:02 +0000 (19:34 -0500)]
Drop gtk_events_pending
This was just a thin wrapper around gtk_main_context_pending,
which should be used directly instead.
Matthias Clasen [Mon, 10 Feb 2020 00:29:16 +0000 (19:29 -0500)]
tests: Stop using gtk_events_pending
Just use the GMainContext api directly.
Matthias Clasen [Mon, 10 Feb 2020 00:27:59 +0000 (19:27 -0500)]
win32 printing: Stop using gtk_events_pending
Just use the GMainContext API directly.
Matthias Clasen [Mon, 10 Feb 2020 04:04:10 +0000 (23:04 -0500)]
win32: One more build fix
Matthias Clasen [Mon, 10 Feb 2020 03:58:53 +0000 (22:58 -0500)]
win32: Fix the build
Matthias Clasen [Mon, 10 Feb 2020 03:55:11 +0000 (03:55 +0000)]
Merge branch 'main-cleanup' into 'master'
Cleanup in gtkmain.h
See merge request GNOME/gtk!1403
Benjamin Otte [Sun, 26 Aug 2018 16:00:52 +0000 (18:00 +0200)]
filechooser: Remove outdated hack
In GTK2, the filechooser was using a Paned, so switching between sidebar
and files list with the arrow keys didn't work (the slider would be
selected instead). So in
https://bugzilla.gnome.org/show_bug.cgi?id=161489 a crude hack was added
to make this possible.
Over the years the filechooser code has changed so that it now would do
this by default, yet the hack had been retained.
Benjamin Otte [Mon, 20 Aug 2018 04:20:05 +0000 (06:20 +0200)]
gdk: Make gdk_keyval_name() return a const char
The string is const, so return it like that.
Matthias Clasen [Sun, 9 Feb 2020 21:49:53 +0000 (16:49 -0500)]
Remove unused include
Emmanuele Bassi [Thu, 6 Feb 2020 15:02:02 +0000 (15:02 +0000)]
cssprovider: Remove unused include
Matthias Clasen [Sun, 9 Feb 2020 16:00:53 +0000 (11:00 -0500)]
Remove gtk_propagate_event from public API
This is not a function that can be safely called
outside of GTK.
Matthias Clasen [Sun, 9 Feb 2020 15:55:56 +0000 (10:55 -0500)]
Remove gtk_main_do_event from public API
Matthias Clasen [Sun, 9 Feb 2020 15:55:37 +0000 (10:55 -0500)]
Remove gtk_main_do_event from the docs
Matthias Clasen [Sun, 9 Feb 2020 15:54:26 +0000 (10:54 -0500)]
testsuite: Stop using gtk_main_do_event
Instead, emit ::event on the surface. Neither of
these is a proper test api, but one works as well
as the other.
Matthias Clasen [Sun, 9 Feb 2020 15:45:33 +0000 (10:45 -0500)]
docs: Remove more mentions of gtk_main_do_event
Matthias Clasen [Sun, 9 Feb 2020 15:38:01 +0000 (10:38 -0500)]
docs: Remove a reference to gtk_main_do_event
It is not great to put a function in the public api and
document it as "do not call this" only so we can refer
to its docs in other places. Therefore, fold the docs
directly into the input handling overview chapter.
Matthias Clasen [Sun, 9 Feb 2020 15:37:24 +0000 (10:37 -0500)]
docs: Remove a mention of gtk_main_do_event
Matthias Clasen [Sun, 9 Feb 2020 15:23:27 +0000 (10:23 -0500)]
css: Add a comment
All the other color values have this comment,
best to be consistent.
Matthias Clasen [Sun, 9 Feb 2020 15:03:44 +0000 (15:03 +0000)]
Merge branch 'wip/baedert/remove-outline-properties' into 'master'
css: Remove outline border radius properties
Closes #2414
See merge request GNOME/gtk!1402
Matthias Clasen [Sun, 9 Feb 2020 00:40:56 +0000 (19:40 -0500)]
gsk: Update docs sections
Matthias Clasen [Sun, 9 Feb 2020 00:36:25 +0000 (19:36 -0500)]
gsk: Small documentation additions
Matthias Clasen [Sun, 9 Feb 2020 00:27:32 +0000 (19:27 -0500)]
Fix a doc comment
Signals take two colons.
Matthias Clasen [Sun, 9 Feb 2020 00:25:13 +0000 (19:25 -0500)]
docs: Drop a few no longer existing symbols
Matthias Clasen [Sun, 9 Feb 2020 00:22:23 +0000 (19:22 -0500)]
docs: Update the switch thumbnail
Make the thumbnail for switches reflect the
current appearance of this widget.
Matthias Clasen [Sun, 9 Feb 2020 00:21:57 +0000 (19:21 -0500)]
emojichooser: Fix the docs
Make the emojichooser show up in the docs.
Matthias Clasen [Sun, 9 Feb 2020 00:04:19 +0000 (19:04 -0500)]
Fix the build with -Dgtk_doc=true
We need to export the emoji chooser symbols to
really make it public api.
Matthias Clasen [Sun, 9 Feb 2020 00:02:46 +0000 (19:02 -0500)]
Fix build with -Dgtk_doc=true
Toolbars were removed, so don't try to create
thumbnails of them.
Timm Bäder [Sat, 8 Feb 2020 19:39:08 +0000 (20:39 +0100)]
css: Remove outline border radius properties
These are always set to the same value as the corresponding border
radius properties. They are also non-standard, so remove them and
replace them with the border radius properties everywhere.
Fixes #2414
Matthias Clasen [Sat, 8 Feb 2020 15:44:16 +0000 (15:44 +0000)]
Merge branch 'avoid-mime-sniffing' into 'master'
Avoid mime sniffing where possible
See merge request GNOME/gtk!1400